add greendot algo #689
Closed
add greendot algo #689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It probably makes more sense to include this in the axisregistry. |
|
Just tested it for the Bricolage project, it's super useful, thanks a lot!! |
|
I tried to read the referenced document: https://docs.google.com/document/d/15652Yabs0prnocpjG1TxG6zrfFSIYqOwlSIMkdbgqfg/edit?resourcekey=0-DXNZQLV2TbSqyn9HCLfhFA but it is not public. It should either be accessible or the inline documentation should be fleshed out. |
|
Also tested for Illusio. It has an 8-144 range, and the tool thrown this values: |
|
Closing since I've moved this to the axisregistry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still WIP.
@RosaWagner @emmamarichal to run this tool use the following command
python -m gftools.greendot min_opsz,max_opsze.g for Imbuepython -m gftools.greendot 10,100.So far my code passes all the examples listed in the greendot doc. However, I still need to clean up and check more. I think I'm missing some edgecases.