Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sample Codelab #325

Merged
merged 3 commits into from
Aug 28, 2019
Merged

Conversation

Mrc0113
Copy link
Contributor

@Mrc0113 Mrc0113 commented Jul 23, 2019

@marcacohen this is the pull request adding the sample codelab "Codelab-4-Codelab" that we discussed in the authors group. I'm allowing edits from maintainers if you want to move it elsewhere.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@Mrc0113
Copy link
Contributor Author

Mrc0113 commented Jul 23, 2019

added email to account for cla...hopefully this will work :)

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@mco-gh mco-gh self-requested a review July 25, 2019 09:40
@mco-gh
Copy link
Contributor

mco-gh commented Jul 25, 2019

Looks good! A few minor points:

  • Lots of use of ampersand in place of the word "and". It's a stylistic choice but I find using the word vs. the symbol looks bit more polished. Maybe a generational thing. :)

  • Markdown syntax backup step, wasn't sure what that is. Backup for what? Maybe state the purpose of that step clearly in the step content and also include a link to a more definitive comprehensive source on md syntax.

  • If you haven't done this yet I'd suggest testing this codelab on someone who has never used claat before, to flush out any environmental surprises or other problems you can't see because you've been using claat for a while.

@Mrc0113
Copy link
Contributor Author

Mrc0113 commented Jul 25, 2019

Thanks for the comments @marcacohen. I'll be out on vacation for a week or so but I'll take a look when I get back.

@mco-gh
Copy link
Contributor

mco-gh commented Jul 25, 2019 via email

@Mrc0113
Copy link
Contributor Author

Mrc0113 commented Aug 27, 2019

@marcacohen
thanks for the feedback. Concerns addressed.

  • Replaced & with "and" ....this is a bad habit of mine
  • Removed 'Markdown Backup' section
  • Had 2 different people go through codelab (1 on Linux and 1 on Windows) and incorporated feedback

Copy link
Contributor

@mco-gh mco-gh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks!

@mco-gh mco-gh merged commit b4d6882 into googlecodelabs:master Aug 28, 2019
@mco-gh
Copy link
Contributor

mco-gh commented Aug 28, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants