-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sample Codelab #325
Add Sample Codelab #325
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
1 similar comment
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
added email to account for cla...hopefully this will work :) |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
1 similar comment
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Looks good! A few minor points:
|
Thanks for the comments @marcacohen. I'll be out on vacation for a week or so but I'll take a look when I get back. |
That's fine, no rush. Have a great vacation!
…On Thu, 25 Jul 2019, 22:22 Marc DiPasquale, ***@***.***> wrote:
Thanks for the comments @marcacohen <https://github.com/marcacohen>. I'll
be out on vacation for a week or so but I'll take a look when I get back.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#325?email_source=notifications&email_token=AAFAXF5EUNRKWE3QGGUL6I3QBIKRTA5CNFSM4IGH56AKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD222AFI#issuecomment-515219477>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFAXF4AT7OK7USPUZAXJE3QBIKRTANCNFSM4IGH56AA>
.
|
@marcacohen
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, thanks!
Good work, reviewed, approved, and merged. Thanks Marc!
…On Tue, 27 Aug 2019 at 21:25, Marc DiPasquale ***@***.***> wrote:
@marcacohen <https://github.com/marcacohen>
thanks for the feedback. Concerns addressed.
- Replaced & with "and" ....this is a bad habit of mine
- Removed 'Markdown Backup' section
- Had 2 different people go through codelab (1 on Linux and 1 on
Windows) and incorporated feedback
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#325?email_source=notifications&email_token=AAFAXF43FFB4KWWEHDKIP5DQGWETPA5CNFSM4IGH56AKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5JAGAQ#issuecomment-525468418>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFAXF6FPM2XCTCUJNIJWN3QGWETPANCNFSM4IGH56AA>
.
--
Marc Cohen
mco@google.com
http://about.me/marc1
|
@marcacohen this is the pull request adding the sample codelab "Codelab-4-Codelab" that we discussed in the authors group. I'm allowing edits from maintainers if you want to move it elsewhere.