Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

embedded iframes are generated with the wrong css class #311

Closed
mco-gh opened this issue Jul 11, 2019 · 1 comment
Closed

embedded iframes are generated with the wrong css class #311

mco-gh opened this issue Jul 11, 2019 · 1 comment
Assignees

Comments

@mco-gh
Copy link
Contributor

mco-gh commented Jul 11, 2019

@Mrc0113 13 says...
I think there may be an issue where the iframes that aren't youtube videos are still labeled as the class="youtube-video" instead of the other one that was added.

Generated code from your example:

<iframe class="youtube-video" src="https://repl.it/@marcacohen/FrigidVacantAdmins?lite=true"></iframe>

Marc C says...
Thanks Marc! PR approved. The embedded-iframe class is identically defined with the youtube-video class so there's no functional problem but I agree it can cause confusion to anyone perusing the generated artifacts. I've fixed this in a private repo but I need to update the distributed css first to avoid breakage and there seems to be a problem with the latter. I'm gonna dump this conversation into a repo issue and when the css distro gets fixed, I'll submit this PR.

@mco-gh mco-gh self-assigned this Jul 11, 2019
@mco-gh
Copy link
Contributor Author

mco-gh commented Sep 18, 2019

css distro updated, this PR can go ahead

@mco-gh mco-gh closed this as completed Sep 18, 2019
mco-gh added a commit that referenced this issue Sep 18, 2019
nicolasgarnier pushed a commit that referenced this issue Sep 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant