Skip to content
This repository has been archived by the owner on Apr 23, 2021. It is now read-only.

Adding tests for sendWebPush #18

Merged
merged 1 commit into from
Apr 1, 2016
Merged

Adding tests for sendWebPush #18

merged 1 commit into from
Apr 1, 2016

Conversation

wibblymat
Copy link
Contributor

@gauntface This is your PR #11 which I have rebased, fixed after changes on master, and then made a few small changes to.

Biggest functional change is that encrypt now let's message be a String or a Buffer. It should really have been in it's own PR, I guess, but I thought of it while doing this one. ¯\_(ツ)_/¯

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

@wibblymat
Copy link
Contributor Author

@googlebot <iframe width="560" height="315" src="https://www.youtube.com/embed/pWdd6_ZxX8c" frameborder="0" allowfullscreen></iframe>

Yeah, well, you know, that's just like, uh, your opinion, man

@gauntface
Copy link
Contributor

@wibblymat what do you want to do about this?

@wibblymat
Copy link
Contributor Author

It's not a big deal, we just override the check. We just have to make sure
that WE believe that everyone has signed a CLA. It was only when we had the
strictest form of branch protection on that it was a problem.

On Thu, 31 Mar 2016 at 18:36 Matthew Gaunt notifications@github.com wrote:

@wibblymat https://github.com/wibblymat what do you want to do about
this?


You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#18 (comment)

@gauntface
Copy link
Contributor

LGTM from me.

@wibblymat wibblymat merged commit e819175 into master Apr 1, 2016
@wibblymat wibblymat deleted the tests-sendwebpush-mat branch April 1, 2016 13:05
@wibblymat wibblymat mentioned this pull request Apr 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants