Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow string as body #6

Merged
merged 1 commit into from
Sep 18, 2018
Merged

fix: allow string as body #6

merged 1 commit into from
Sep 18, 2018

Conversation

kjin
Copy link
Contributor

@kjin kjin commented Sep 17, 2018

It seems like request allows body to be a string, so cover that case here.

I believe this can circumvent a code change that would otherwise be needed as part of googleapis/cloud-trace-nodejs#858.

Copy link
Contributor

@fhinkel fhinkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fhinkel fhinkel merged commit 204c34e into googleapis:master Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants