Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(python): fix line breaks in template and use newer black version #643

Merged
merged 2 commits into from
Jun 23, 2020
Merged

chore(python): fix line breaks in template and use newer black version #643

merged 2 commits into from
Jun 23, 2020

Conversation

busunkim96
Copy link
Contributor

@busunkim96 busunkim96 commented Jun 23, 2020 •
edited
Loading

session.install("mock", "pytest", "pytest-cov") gets appended onto the previous line

It also appears we need to bump the black version to avoid running into psf/black#875

@busunkim96 busunkim96 requested a review from plamut June 23, 2020 02:46
@busunkim96 busunkim96 requested a review from a team as a code owner June 23, 2020 02:46
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 23, 2020
@busunkim96 busunkim96 closed this Jun 23, 2020
@busunkim96 busunkim96 reopened this Jun 23, 2020
@busunkim96 busunkim96 added the automerge Merge the pull request once unit tests and other checks pass. label Jun 23, 2020
@busunkim96 busunkim96 changed the title chore(python): fix line breaks in template chore(python): fix line breaks in template and use newer black version Jun 23, 2020
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

1 similar comment
@gcf-merge-on-green
Copy link
Contributor

Your PR has attempted to merge for 3 hours. Please check that all required checks have passed, you have an automerge label, and that all your reviewers have approved the PR

@gcf-merge-on-green
Copy link
Contributor

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, or one of your required reviews was not approved. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 23, 2020
plamut
plamut approved these changes Jun 23, 2020
View reviewed changes
Copy link

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plamut
Copy link

plamut commented Jun 23, 2020

Doing the automerge on behalf of the bot :)

@plamut plamut merged commit cf2eff0 into master Jun 23, 2020
@SurferJeffAtGoogle SurferJeffAtGoogle deleted the busunkim96-patch-4 branch June 26, 2020 21:59
@tswast tswast mentioned this pull request Aug 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@busunkim96 @plamut @googlebot