Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(python): add defaults for microgenerator libraries #642

Merged
merged 5 commits into from
Jun 23, 2020
Merged

feat(python): add defaults for microgenerator libraries #642

merged 5 commits into from
Jun 23, 2020

Conversation

busunkim96
Copy link
Contributor

No description provided.

@busunkim96 busunkim96 requested review from SurferJeffAtGoogle and a team as code owners June 20, 2020 01:47
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 20, 2020
plamut
plamut reviewed Jun 22, 2020
View reviewed changes
Copy link

@plamut plamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good IMO, just have a question about the the latest Python version used.

synthtool/gcp/common.py Outdated Show resolved Hide resolved
@busunkim96 busunkim96 requested a review from plamut June 22, 2020 17:32
@sofisl sofisl added the automerge Merge the pull request once unit tests and other checks pass. label Jun 23, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit db4f15f into master Jun 23, 2020
@busunkim96 busunkim96 deleted the microgen-templates branch June 23, 2020 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

@SurferJeffAtGoogle SurferJeffAtGoogle Awaiting requested review from SurferJeffAtGoogle

Assignees
No one assigned
Labels
automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@busunkim96 @plamut @googlebot @sofisl