Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(java): Add -ntp flag to native image testing command #1299

Merged
merged 1 commit into from
Dec 6, 2021
Merged

fix(java): Add -ntp flag to native image testing command #1299

merged 1 commit into from
Dec 6, 2021

Conversation

dzou
Copy link
Contributor

@dzou dzou commented Dec 3, 2021

This adds the -ntp flag to native image testing command to produce more readable test log outputs.

@dzou dzou requested review from lesv and Neenu1995 December 3, 2021 00:48
@dzou dzou requested a review from a team as a code owner December 3, 2021 00:48
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 3, 2021
@lesv lesv added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2021
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 3, 2021
chanseokoh
chanseokoh reviewed Dec 3, 2021
View reviewed changes
Copy link
Contributor

@chanseokoh chanseokoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While we're at it, how about adding it to all other mvn commands? Like for test, lint, javadoc, etc. It's really annonying.

@chanseokoh
Copy link
Contributor

Also with -B where it's missing.

@dzou dzou merged commit 723f3ce into master Dec 6, 2021
@dzou dzou deleted the fix-native-test-cmd branch December 6, 2021 16:14
@dzou
Copy link
Contributor Author

dzou commented Dec 6, 2021

While we're at it, how about adding it to all other mvn commands? Like for test, lint, javadoc, etc. It's really annonying.

Yes, this can be done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chanseokoh chanseokoh chanseokoh left review comments

@lesv lesv lesv approved these changes

@suztomo suztomo suztomo approved these changes

@Neenu1995 Neenu1995 Awaiting requested review from Neenu1995

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dzou @chanseokoh @suztomo @lesv @kokoro-team