feat: add MoveObject to json and grpc #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cojenco
approved these changes
Jan 14, 2025
There was a problem hiding this comment.
Thanks for working on this. Reading through the api design doc, IIUC MoveObject is for HNS-enabled buckets only.
HNS and storage control are not typically within the scope of the testbench. If this PR is necessary for testing MoveObject, happy to merge it in. I simply wanted to highlight that the testbench lacks HNS support, which may present limitations for feature expansions.
cojenco
reviewed
Jan 14, 2025
cojenco
reviewed
Jan 14, 2025
testbench/grpc_server.py
Outdated
| @@ -805,6 +805,40 @@ def RestoreObject(self, request, context): | |||
| ) | |||
| return blob.metadata | |||
|
|
|||
| @retry_test(method="storage.objects.move") | |||
There was a problem hiding this comment.
Could we remove the retry_test decorators here and in rest_server and also add comments that this is partially supported only to test single object, thanks!
cojenco
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #<issue_number_goes_here>