Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: enable more methods for retry test support in gRPC #628

Merged
merged 4 commits into from
Apr 15, 2024
Merged

feat: enable more methods for retry test support in gRPC #628

merged 4 commits into from
Apr 15, 2024

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Apr 11, 2024 •
edited
Loading

Allow more methods for Retry Test support in gRPC

  • equip gRPC endpoints with @retry_test decorator
  • update __validate_grpc_method_implemented_retry guard
  • 501 Unimplemented exceptions are only raised for ACL and notifications test cases that are not applicable in gRPC

@cojenco cojenco marked this pull request as ready for review April 11, 2024 21:56
@cojenco cojenco requested review from coryan and a team as code owners April 11, 2024 21:56
tritone
tritone approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the PR out for Go and the only thing that fails is notifications methods in gRPC. Once we skip those I'm good to merge.

testbench/database.py Show resolved Hide resolved
@cojenco cojenco added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 11, 2024
@cojenco cojenco removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 15, 2024
@cojenco
Copy link
Contributor Author

cojenco commented Apr 15, 2024

Checked with java folks - no issues with merging while we're tracking work in internal go/gcs-testbench-grpc-server-client

Codecov upload issue is irrelevant to the changes in this PR; #630 and internal b/334987416 track next steps

@cojenco cojenco merged commit 8917c3f into googleapis:main Apr 15, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tritone tritone tritone approved these changes

@coryan coryan Awaiting requested review from coryan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cojenco @tritone @coryan