fix: predefinedACL replaces existing ACL in object patch/update #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #352 +/- ##
==========================================
- Coverage 92.58% 92.56% -0.02%
==========================================
Files 51 51
Lines 8101 8108 +7
==========================================
+ Hits 7500 7505 +5
- Misses 601 603 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
coryan
approved these changes
May 26, 2022
testbench/grpc_server.py
Outdated
| @@ -510,6 +510,17 @@ def UpdateObject(self, request, context): | |||
| if "metadata" in request.update_mask.paths: | |||
| blob.metadata.metadata.clear() | |||
| blob.metadata.metadata.update(request.object.metadata) | |||
| # Manually handle PredefinedACL. | |||
There was a problem hiding this comment.
nit: do we spell that predefinedACL ?
There was a problem hiding this comment.
Fixed, thanks! Losing track of all the different cases
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #351
PredefinedACL replaces the existing object ACL in
gRPC.UpdateObject,object.updateandobject.patchoperations