Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve DefaultObjectAccessControl: * responses #346

Merged
merged 1 commit into from
May 19, 2022
Merged

feat: improve DefaultObjectAccessControl: * responses #346

merged 1 commit into from
May 19, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented May 19, 2022

Just like for bucket and object access controls, we need to enrich the
responses for DefaultObjectAccessControl: *. I also made the testing
more consistent across all three resources.

Fixes #338

Just like for bucket and object access controls, we need to enrich the
responses for `DefaultObjectAccessControl: *`.  I also made the testing
more consistent across all three resources.
@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #346 (d3a65ff) into main (40c5f06) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #346   +/-   ##
=======================================
  Coverage   92.53%   92.54%           
=======================================
  Files          51       51           
  Lines        8056     8065    +9     
=======================================
+ Hits         7455     7464    +9     
  Misses        601      601           
Flag Coverage Δ
unittests 92.54% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
testbench/proto2rest.py 98.90% <100.00%> (+0.03%) ⬆️
testbench/rest_server.py 98.61% <100.00%> (-0.02%) ⬇️
tests/test_proto2rest.py 97.22% <100.00%> (+0.55%) ⬆️
tests/test_testbench_bucket.py 99.09% <100.00%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40c5f06...d3a65ff. Read the comment docs.

@coryan coryan marked this pull request as ready for review May 19, 2022 21:12
@coryan coryan requested review from a team as code owners May 19, 2022 21:12
@coryan coryan merged commit 7834b46 into googleapis:main May 19, 2022
@coryan coryan deleted the feat-improve-default-object-acl-responses branch May 19, 2022 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Many fields not filled in *AccessControl: * operations
2 participants