Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve BucketAcl: * responses #342

Merged
merged 2 commits into from
May 18, 2022
Merged

feat: improve BucketAcl: * responses #342

merged 2 commits into from
May 18, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented May 18, 2022

Add attributes not present in the protos.

Part of the work for #338

Add attributes not present in the protos.
@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #342 (b5aaf3b) into main (f08f755) will increase coverage by 0.01%.
The diff coverage is 97.43%.

@@            Coverage Diff             @@
##             main     #342      +/-   ##
==========================================
+ Coverage   92.50%   92.51%   +0.01%     
==========================================
  Files          50       51       +1     
  Lines        7988     8013      +25     
==========================================
+ Hits         7389     7413      +24     
- Misses        599      600       +1     
Flag Coverage Δ
unittests 92.51% <97.43%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
tests/test_proto2rest.py 92.30% <92.30%> (ø)
testbench/proto2rest.py 98.07% <100.00%> (+0.11%) ⬆️
testbench/rest_server.py 98.64% <100.00%> (-0.02%) ⬇️
tests/test_testbench_bucket.py 99.06% <100.00%> (+0.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f08f755...b5aaf3b. Read the comment docs.

@coryan coryan marked this pull request as ready for review May 18, 2022 00:02
@coryan coryan requested review from a team as code owners May 18, 2022 00:02
tests/test_proto2rest.py Outdated Show resolved Hide resolved
@coryan coryan merged commit 28016b8 into googleapis:main May 18, 2022
@coryan coryan deleted the feat-improve-bucket-acl-responses branch May 18, 2022 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants