Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grpc): correct prefix for project resources #280

Merged
merged 1 commit into from
Feb 14, 2022
Merged

fix(grpc): correct prefix for project resources #280

merged 1 commit into from
Feb 14, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Feb 14, 2022

This was breaking some of my integration tests for the C++ client library, but only for buckets created with gRPC. Sigh.

@codecov
Copy link

codecov bot commented Feb 14, 2022

Codecov Report

Merging #280 (7ea5006) into main (b6f22e0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #280   +/-   ##
=======================================
  Coverage   97.62%   97.62%           
=======================================
  Files          48       48           
  Lines        7629     7632    +3     
=======================================
+ Hits         7448     7451    +3     
  Misses        181      181           
Flag Coverage Δ
unittests 97.62% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
gcs/bucket.py 98.62% <100.00%> (ø)
tests/test_bucket_grpc.py 96.29% <100.00%> (+0.14%) ⬆️
tests/test_grpc_server.py 99.84% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b6f22e0...7ea5006. Read the comment docs.

@coryan coryan marked this pull request as ready for review February 14, 2022 18:17
@coryan coryan requested a review from a team as a code owner February 14, 2022 18:17
@coryan coryan enabled auto-merge (squash) February 14, 2022 18:17
@coryan coryan merged commit d2f4dc0 into googleapis:main Feb 14, 2022
@coryan coryan deleted the fix-grpc-create-bucket-project-number branch February 14, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants