Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for return-broken-stream-after-YK #276

Merged
merged 3 commits into from
Feb 9, 2022

Conversation

cojenco
Copy link
Contributor

@cojenco cojenco commented Feb 9, 2022

Fixes #173

This introduces support for return-broken-stream-after-YK of downloaded data in the Retry Test API.
To better test complex download scenarios in the retry conformance tests, we've discussed to test larger files and add support for "after-YK" instead of "after-YB"

  • Tests pass
  • Appropriate changes to README are included in PR

@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #276 (f8ed389) into main (ebf4d23) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #276   +/-   ##
=======================================
  Coverage   97.61%   97.62%           
=======================================
  Files          48       48           
  Lines        7598     7629   +31     
=======================================
+ Hits         7417     7448   +31     
  Misses        181      181           
Flag Coverage Δ
unittests 97.62% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
testbench/database.py 100.00% <ø> (ø)
testbench/common.py 98.67% <100.00%> (+0.02%) ⬆️
tests/test_testbench_retry.py 99.47% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebf4d23...f8ed389. Read the comment docs.

@cojenco cojenco marked this pull request as ready for review February 9, 2022 01:28
@cojenco cojenco requested review from coryan and a team as code owners February 9, 2022 01:28
Copy link
Contributor

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple little comments, LGTM overall. Thanks!

testbench/common.py Outdated Show resolved Hide resolved
testbench/common.py Show resolved Hide resolved
testbench/common.py Show resolved Hide resolved
testbench/common.py Outdated Show resolved Hide resolved
testbench/common.py Show resolved Hide resolved
testbench/common.py Show resolved Hide resolved
@tritone tritone merged commit b6f22e0 into googleapis:main Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support return-broken-stream-after-YB
3 participants