Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(grpc): more problems with UpdateObject()/UpdateBucket() #271

Merged
merged 1 commit into from
Feb 2, 2022
Merged

fix(grpc): more problems with UpdateObject()/UpdateBucket() #271

merged 1 commit into from
Feb 2, 2022

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Feb 2, 2022

I thought my previous tests had reproduced and fixed the problem, but
evidently this is not the case. It all seems to be working correctly
now, tested using the C++ client library. I also filed a bug against
the protobuf project, and another bug to cleanup this code when the
protobuf bug is fixed.

See #270 for more details.

I thought my previous tests had reproduced and fixed the problem, but
evidently this is not the case.  It all seems to be working correctly
now, tested using the C++ client library.  I also filed a bug against
the protobuf project, and another bug to cleanup this code when the
protobuf bug is fixed.
@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #271 (e16dac3) into main (9a145b0) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #271   +/-   ##
=======================================
  Coverage   97.61%   97.61%           
=======================================
  Files          48       48           
  Lines        7582     7598   +16     
=======================================
+ Hits         7401     7417   +16     
  Misses        181      181           
Flag Coverage Δ
unittests 97.61% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
testbench/grpc_server.py 100.00% <100.00%> (ø)
tests/test_grpc_server.py 99.84% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a145b0...e16dac3. Read the comment docs.

@coryan coryan marked this pull request as ready for review February 2, 2022 14:27
@coryan coryan requested a review from a team as a code owner February 2, 2022 14:27
@coryan coryan enabled auto-merge (squash) February 2, 2022 14:27
@coryan coryan merged commit 7cc5e11 into googleapis:main Feb 2, 2022
@coryan coryan deleted the fix-grpc-another-round-of-UpdateObject-UpdateBucket branch February 2, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants