Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move owlbot requirements to library_generation/reqs.in #2471

Merged
merged 4 commits into from
Feb 13, 2024

Conversation

diegomarquezp
Copy link
Contributor

No description provided.

Copy link

conventional-commit-lint-gcf bot commented Feb 13, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Feb 13, 2024
@diegomarquezp
Copy link
Contributor Author

diegomarquezp commented Feb 13, 2024

Fails for apigee-connect

FAIL: test_generate_repo (test.integration_tests.IntegrationTest.test_generate_repo)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/usr/local/google/home/diegomarquezp/Desktop/sdk-platform-java/library_generation/test/integration_tests.py", line 76, in test_generate_repo
    self.assertEqual([], compare_result.right_only)
AssertionError: Lists differ: [] != ['v1']

Second list contains 1 additional elements.
First extra element 0:
'v1'

- []
+ ['v1']

Involved code:

compare_result = dircmp(
f"{golden_dir}/{library_name}",
f"{repo_dest}/{library_name}",
ignore=[".repo-metadata.json"],
)
# compare source code
self.assertEqual([], compare_result.left_only)
self.assertEqual([], compare_result.right_only)
self.assertEqual([], compare_result.diff_files)

@diegomarquezp diegomarquezp marked this pull request as ready for review February 13, 2024 18:31
@diegomarquezp diegomarquezp requested a review from a team as a code owner February 13, 2024 18:31
Copy link

Quality Gate Passed Quality Gate passed for 'gapic-generator-java-root'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@JoeWang1127 JoeWang1127 merged commit b76690e into main Feb 13, 2024
28 of 30 checks passed
@JoeWang1127 JoeWang1127 deleted the move-owlbot-requirements branch February 13, 2024 18:55
ddixit14 pushed a commit that referenced this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants