Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate calls to setters in gax-java/gax-grpc/src/test/java/com/google/api/gax/grpc/TimeoutTest #2635

Closed
cushon opened this issue Apr 12, 2024 · 0 comments · Fixed by #2636
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.

Comments

@cushon
Copy link
Contributor

cushon commented Apr 12, 2024

There are some duplicated calls to setter methods in gax-java/gax-grpc/src/test/java/com/google/api/gax/grpc/TimeoutTest.java:

.setRpcTimeoutMultiplier(1.0)
.setRpcTimeoutMultiplier(1.0)

The calls are redundant, can can be removed.

These were noticed by https://errorprone.info/bugpattern/RedundantSetterCall

@diegomarquezp diegomarquezp added type: process A process-related concern. May include testing, release, or the like. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Apr 16, 2024
lqiu96 pushed a commit that referenced this issue Apr 17, 2024
This change removes duplicate calls to setters in
`gax-java/gax-grpc/src/test/java/com/google/api/gax/grpc/TimeoutTest.java`.

Fixes #2635 ☕️

Co-authored-by: Blake Li <blakeli@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: process A process-related concern. May include testing, release, or the like.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants