Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

[CHANGE ME] Re-generated to pick up changes from synthtool. #64

Closed
wants to merge 5 commits into from

Conversation

yoshi-automation
Copy link
Contributor

@yoshi-automation yoshi-automation commented Sep 3, 2020

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/7d962ed0-9b50-494a-be20-1e850f7f26bd/targets

  • To automatically regenerate this PR, check this box.

Source-Link: googleapis/synthtool@1f1148d
Source-Link: googleapis/synthtool@3d3e94c
Source-Link: googleapis/synthtool@6542bd7
Source-Link: googleapis/synthtool@ea52b8a

@yoshi-automation yoshi-automation requested review from sirtorry and a team as code owners September 3, 2020 14:30
@yoshi-automation yoshi-automation requested review from leahecole and removed request for a team September 3, 2020 14:30
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 3, 2020
@product-auto-label product-auto-label bot added the api: translate Issues related to the googleapis/python-translate API. label Sep 4, 2020
@leahecole
Copy link
Contributor

For the two noxfiles, it looks like it just switched what type of quotes were used in each, but it's not consistent as to what type of quotes it's using throughout. @busunkim96 is this a concern?

Copy link
Contributor

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

samples lgtm

        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
Source-Author: Tim Swast <swast@google.com>
Source-Date: Tue Oct 27 12:01:14 2020 -0500
Source-Repo: googleapis/synthtool
Source-Sha: ea52b8a0bd560f72f376efcf45197fb7c8869120
Source-Link: googleapis/synthtool@ea52b8a
I recently submitted https://github.com/googleapis/synthtool/pull/811/files, allowing external dependencies for unit tests. This fixes a small missing comma bug

Source-Author: Daniel Sanche <d.sanche14@gmail.com>
Source-Date: Thu Oct 29 16:58:01 2020 -0700
Source-Repo: googleapis/synthtool
Source-Sha: 6542bd723403513626f61642fc02ddca528409aa
Source-Link: googleapis/synthtool@6542bd7
Source-Author: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Source-Date: Wed Nov 4 17:36:32 2020 -0800
Source-Repo: googleapis/synthtool
Source-Sha: 3d3e94c4e02370f307a9a200b0c743c3d8d19f29
Source-Link: googleapis/synthtool@3d3e94c
Source-Author: Leah E. Cole <6719667+leahecole@users.noreply.github.com>
Source-Date: Thu Nov 5 15:22:03 2020 -0800
Source-Repo: googleapis/synthtool
Source-Sha: 1f1148d3c7a7a52f0c98077f976bd9b3c948ee2b
Source-Link: googleapis/synthtool@1f1148d
@leahecole
Copy link
Contributor

Lint fix submitted here: googleapis/synthtool#847

@busunkim96 busunkim96 closed this Dec 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: translate Issues related to the googleapis/python-translate API. cla: yes This human has signed the Contributor License Agreement. context: partial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants