Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass through route-to-leader option in dbapi #1223

Merged
merged 3 commits into from
Nov 11, 2024
Merged

fix: pass through route-to-leader option in dbapi #1223

merged 3 commits into from
Nov 11, 2024

Conversation

olavloite
Copy link
Contributor

The route-to-leader option given to the dbapi connection was not passed on to the actual Spanner client.

@olavloite
fix: pass through route-to-leader option in dbapi
fa8e006 
The route-to-leader option given to the dbapi connection was not passed
on to the actual Spanner client.
@olavloite olavloite requested review from a team as code owners November 4, 2024 16:13
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/python-spanner API. labels Nov 4, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Nov 4, 2024
@olavloite olavloite mentioned this pull request Nov 4, 2024
Open
@harshachinta
Copy link
Contributor

@olavloite
There seems to be an issue with the kokoro build and it is unrelated to this PR changes.
Looks like some change in kokoro configuration which is causing the issue. Will check with Python SDK team and get back.

@harshachinta
Copy link
Contributor

@olavloite There seems to be an issue with the kokoro build and it is unrelated to this PR changes. Looks like some change in kokoro configuration which is causing the issue. Will check with Python SDK team and get back.

This issue is fixed now. The builds should be green.

@olavloite olavloite added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 11, 2024
@olavloite olavloite merged commit ec6c204 into main Nov 11, 2024
13 of 16 checks passed
@olavloite olavloite deleted the fix-pass-through-route-to-leader branch November 11, 2024 08:15
@release-please release-please bot mentioned this pull request Nov 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rahul2393 rahul2393 rahul2393 approved these changes

@harshachinta harshachinta Awaiting requested review from harshachinta

Assignees

@pratickchokhani pratickchokhani

Labels
api: spanner Issues related to the googleapis/python-spanner API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@olavloite @harshachinta @rahul2393 @pratickchokhani @yoshi-kokoro