test: add mock server tests #1217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a DatabaseAdminService to the mock server and sets up a basic test case for this. Also removes the generated stubs in the grpc files, as these are not needed.
harshachinta
approved these changes
Dec 5, 2024
| # Generated by the gRPC Python protocol compiler plugin. DO NOT EDIT! | ||
|
|
||
|
|
||
| # Generated with the following commands: |
There was a problem hiding this comment.
It seems that whenever a new admin API is introduced, this file will need to be regenerated. Alternatively, we should explore if there’s an automated way to update or refresh this file.
However, this is currently out of scope from mock server functionality and not a high priority.
There was a problem hiding this comment.
I agree. Having this auto-generated would be nice. But we only really need to re-generate if there's a new feature that we actually also want to include in the mock server tests. Nothing should break if a new feature that we just don't try to use is introduced.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a mock server and tests for the Python client.