This repository has been archived by the owner on Dec 31, 2023. It is now read-only.
chore: use gapic-generator-python 0.58.4 #260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: provide appropriate mock values for message body fields committer: dovs PiperOrigin-RevId: 419025932 Source-Link: googleapis/googleapis@73da669 Source-Link: https://github.com/googleapis/googleapis-gen/commit/46df624a54b9ed47c1a7eefb7a49413cf7b82f98 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9
1 task
parthea
reviewed
Jan 15, 2022
| @@ -166,14 +166,14 @@ def transport(self) -> MetricServiceTransport: | |||
| return self._transport | |||
|
|
|||
| '''@staticmethod | |||
| def metric_descriptor_path(project: str,) -> str: | |||
| def metric_descriptor_path(project: str,metric_descriptor: str,) -> str: | |||
There was a problem hiding this comment.
This code is commented out so it shouldn't be considered a breaking change.
parthea
reviewed
Jan 15, 2022
| """Returns a fully-qualified metric_descriptor string.""" | ||
| return "projects/{project}/metricDescriptors/{metric_descriptor=**}".format(project=project, ) | ||
| return "projects/{project}/metricDescriptors/{metric_descriptor=**}".format(project=project, metric_descriptor=metric_descriptor, ) |
There was a problem hiding this comment.
I tried uncommenting the code but the unit tests fail as {metric_descriptor=**} is unsupported according to googleapis/gapic-generator-python#701
_________________________________________________________________________________ test_metric_descriptor_path _________________________________________________________________________________
def test_metric_descriptor_path():
project = "squid"
metric_descriptor = "clam"
> expected = "projects/{project}/metricDescriptors/{metric_descriptor=**}".format(
project=project, metric_descriptor=metric_descriptor,
)
E KeyError: 'metric_descriptor=**'
tests/unit/gapic/monitoring_v3/test_metric_service.py:3533: KeyError
______________________________________________________________________________ test_parse_metric_descriptor_path ______________________________________________________________________________
def test_parse_metric_descriptor_path():
expected = {
"project": "whelk",
"metric_descriptor": "octopus",
}
> path = MetricServiceClient.metric_descriptor_path(**expected)
tests/unit/gapic/monitoring_v3/test_metric_service.py:3545:
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _
project = 'whelk', metric_descriptor = 'octopus'
@staticmethod
def metric_descriptor_path(project: str, metric_descriptor: str,) -> str:
"""Returns a fully-qualified metric_descriptor string."""
> return "projects/{project}/metricDescriptors/{metric_descriptor=**}".format(
project=project, metric_descriptor=metric_descriptor,
)
E KeyError: 'metric_descriptor=**'
google/cloud/monitoring_v3/services/metric_service/client.py:171: KeyError
==============================================================================
parthea
approved these changes
Jan 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: provide appropriate mock values for message body fields
committer: dovs
PiperOrigin-RevId: 419025932
Source-Link: googleapis/googleapis@73da669
Source-Link: https://github.com/googleapis/googleapis-gen/commit/46df624a54b9ed47c1a7eefb7a49413cf7b82f98
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDZkZjYyNGE1NGI5ZWQ0N2MxYTdlZWZiN2E0OTQxM2NmN2I4MmY5OCJ9