Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Fixed unsupported resource type in system test #904

Merged
merged 1 commit into from
Jun 7, 2024
Merged

test: Fixed unsupported resource type in system test #904

merged 1 commit into from
Jun 7, 2024

Conversation

gkevinzheng
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@gkevinzheng gkevinzheng requested review from a team as code owners June 6, 2024 16:25
@gkevinzheng gkevinzheng requested a review from cindy-peng June 6, 2024 16:25
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jun 6, 2024
@product-auto-label product-auto-label bot added the api: logging Issues related to the googleapis/python-logging API. label Jun 6, 2024
@gkevinzheng gkevinzheng added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Jun 6, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 6, 2024
@gkevinzheng gkevinzheng enabled auto-merge (squash) June 6, 2024 19:26
@gkevinzheng gkevinzheng added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 7, 2024
@gkevinzheng gkevinzheng merged commit a49f78c into main Jun 7, 2024
17 checks passed
@gkevinzheng gkevinzheng deleted the system-test-fix branch June 7, 2024 14:43
gkevinzheng added a commit that referenced this pull request Jun 24, 2024
@gkevinzheng @gcf-owl-bot
chore: Merge main into experimental-v4 (#906)
bb1f1ef 
* fix: Added missing import into logger.py (#896)

* test: Fixed unsupported resource type in system test (#904)

* fix: Added type hints to CloudLoggingHandler constructor (#903)

* fix: Added type hints to CloudLoggingHandler constructor

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Removed Client typing due to circular imports

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
gkevinzheng added a commit that referenced this pull request Jul 29, 2024
@gkevinzheng @gcf-owl-bot
chore: Merge main into experimental-v4 (#906)
a7b99fd 
* fix: Added missing import into logger.py (#896)

* test: Fixed unsupported resource type in system test (#904)

* fix: Added type hints to CloudLoggingHandler constructor (#903)

* fix: Added type hints to CloudLoggingHandler constructor

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Removed Client typing due to circular imports

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
gkevinzheng added a commit that referenced this pull request Jul 30, 2024
@gkevinzheng @gcf-owl-bot
fix!: Use StructuredLogHandler for Cloud Run Job (#898)
758d439 
* fix!: Use StructuredLogHandler for Cloud Run Job

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* chore: Merge main into experimental-v4 (#906)

* fix: Added missing import into logger.py (#896)

* test: Fixed unsupported resource type in system test (#904)

* fix: Added type hints to CloudLoggingHandler constructor (#903)

* fix: Added type hints to CloudLoggingHandler constructor

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* Removed Client typing due to circular imports

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

* feat!: Use StructuredLogHandler on App Engine instead of CloudLoggingHandler (#908)

* feat!: Use StructuredLogHandler on App Engine instead of
CloudLoggingHandler

* linting

* fix!: Use StructuredLogHandler for Cloud Run Job

* Removed print statement

* Resolved all merge conflicts

* linting

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-sanche daniel-sanche daniel-sanche approved these changes

@cindy-peng cindy-peng cindy-peng approved these changes

Assignees

@cindy-peng cindy-peng

Labels
api: logging Issues related to the googleapis/python-logging API. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gkevinzheng @daniel-sanche @cindy-peng @yoshi-kokoro