Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove collection import #186

Merged
merged 3 commits into from
Sep 16, 2020
Merged

chore: remove collection import #186

merged 3 commits into from
Sep 16, 2020

Conversation

HemangChothani
Copy link
Contributor

Fixes #183

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 8, 2020
@HemangChothani
Copy link
Contributor Author

Unit test failed due new to release of protobuf lib and resolved in #185 PR

@product-auto-label product-auto-label bot added the api: firestore Issues related to the googleapis/python-firestore API. label Sep 9, 2020
tseaver
tseaver suggested changes Sep 14, 2020
View reviewed changes
google/cloud/firestore_v1/field_path.py Outdated Show resolved Hide resolved
@tseaver tseaver added the automerge Merge the pull request once unit tests and other checks pass. label Sep 16, 2020
@gcf-merge-on-green gcf-merge-on-green bot merged commit 581520c into googleapis:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

@crwilcox crwilcox Awaiting requested review from crwilcox

Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/python-firestore API. automerge Merge the pull request once unit tests and other checks pass. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

remove 'collections' import for python2.7
2 participants
@HemangChothani @tseaver