Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

feat!: add support for Virtual Dataproc cluster running on GKE cluster #344

Merged
merged 4 commits into from
Feb 25, 2022
Merged

feat!: add support for Virtual Dataproc cluster running on GKE cluster #344

merged 4 commits into from
Feb 25, 2022

Conversation

gcf-owl-bot[bot]
Copy link
Contributor

@gcf-owl-bot gcf-owl-bot bot commented Feb 16, 2022 •
edited by parthea
Loading

  • Regenerate this pull request now.

Committer: @Padmaar
PiperOrigin-RevId: 429111624

Source-Link: googleapis/googleapis@da999a2

Source-Link: https://github.com/googleapis/googleapis-gen/commit/99c5b3e98baa1de93776aa4b5cd4c7361353e4f6
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTljNWIzZTk4YmFhMWRlOTM3NzZhYTRiNWNkNGM3MzYxMzUzZTRmNiJ9

fix: remove namespaced_gke_deployment_target
fix: move GkeClusterConfig to google.cloud.dataproc_v1.types.shared

@gcf-owl-bot
feat!: add support for Virtual Dataproc cluster running on GKE cluster
c8a081f 
Committer: @Padmaar
PiperOrigin-RevId: 429111624

Source-Link: googleapis/googleapis@da999a2

Source-Link: https://github.com/googleapis/googleapis-gen/commit/99c5b3e98baa1de93776aa4b5cd4c7361353e4f6
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOTljNWIzZTk4YmFhMWRlOTM3NzZhYTRiNWNkNGM3MzYxMzUzZTRmNiJ9
@gcf-owl-bot gcf-owl-bot bot requested a review from a team as a code owner February 16, 2022 21:56
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 16, 2022
@product-auto-label product-auto-label bot added the api: dataproc Issues related to the googleapis/python-dataproc API. label Feb 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2022
@snippet-bot
Copy link

snippet-bot bot commented Feb 16, 2022 •
edited
Loading

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 16, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 16, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 16, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 18, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 18, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 18, 2022
@parthea parthea changed the title feat!: add support for Virtual Dataproc cluster running on GKE cluster feat: add support for Virtual Dataproc cluster running on GKE cluster Feb 18, 2022
@parthea parthea changed the title feat: add support for Virtual Dataproc cluster running on GKE cluster feat!: add support for Virtual Dataproc cluster running on GKE cluster Feb 18, 2022
@parthea parthea added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 18, 2022
@parthea
Copy link
Contributor

parthea commented Feb 18, 2022

Need to confirm with the broader team on whether we need to bump the major version for this breaking change.

@parthea
Copy link
Contributor

parthea commented Feb 18, 2022

Hi @leahecole, Please can you confirm that we should bump the major version for this library for this breaking change?

@parthea
Copy link
Contributor

parthea commented Feb 18, 2022

Also, adding @danoscarmike to confirm that we're taking a breaking change here.

@parthea parthea requested a review from danoscarmike February 18, 2022 11:40
@parthea parthea requested a review from loferris February 24, 2022 18:29
loferris
loferris approved these changes Feb 24, 2022
View reviewed changes
Copy link
Contributor

@loferris loferris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parthea parthea requested a review from a team as a code owner February 24, 2022 19:39
@parthea parthea removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 24, 2022
@trusted-contributions-gcf trusted-contributions-gcf bot added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Feb 24, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 24, 2022
@parthea
Copy link
Contributor

parthea commented Feb 24, 2022

This is ready to merge once tests pass

@parthea parthea added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. and removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 24, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 24, 2022
@parthea parthea self-assigned this Feb 24, 2022
@parthea parthea added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed kokoro:run Add this label to force Kokoro to re-run the tests. labels Feb 24, 2022
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 24, 2022
@parthea parthea added the automerge Merge the pull request once unit tests and other checks pass. label Feb 25, 2022
@gcf-merge-on-green gcf-merge-on-green bot merged commit 116077b into main Feb 25, 2022
@gcf-merge-on-green gcf-merge-on-green bot deleted the owl-bot-copy branch February 25, 2022 01:46
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Feb 25, 2022
@release-please release-please bot mentioned this pull request Feb 25, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@loferris loferris loferris approved these changes

@parthea parthea parthea approved these changes

@danoscarmike danoscarmike danoscarmike approved these changes

@leahecole leahecole Awaiting requested review from leahecole

Assignees

@parthea parthea

Labels
api: dataproc Issues related to the googleapis/python-dataproc API. owl-bot-copy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@parthea @danoscarmike @loferris @leahecole @bradmiro @yoshi-kokoro