-
Notifications
You must be signed in to change notification settings - Fork 25
Conversation
Wait for python 3.10 samples to pass |
# Declare build specific Cloud project. | ||
env_vars: { | ||
key: "BUILD_SPECIFIC_GCLOUD_PROJECT" | ||
value: "python-docs-samples-tests-310" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is breaking naming convention. It should be python-docs-samples-tests-py310
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regretfully, the string python-docs-samples-tests-py310
is 31 characters long which exceeds the Project ID requirement Must be 6 to 30 characters in length
defined here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Well, then there's nothing we can do I guess. In a couple of years, when Python 3.9 is deprecated, we'll be consistent once again 😆
I'm going to try running the python 3.10 tests again to see if it fails again. See build log here.
|
@parthea are you running with different project per different version? Those tests require the |
@m-strzelczyk Please could you review/approve? |
This PR pulls in the latest synthtool templates and adds python 3.10 samples testing.