Skip to content
This repository has been archived by the owner on Dec 31, 2023. It is now read-only.

chore(docs): Adding samples for GCE instance creation #130

Merged
merged 6 commits into from
Oct 19, 2021
Merged

chore(docs): Adding samples for GCE instance creation #130

merged 6 commits into from
Oct 19, 2021

Conversation

m-strzelczyk
Copy link
Contributor

Providing samples for the following docs page:
https://cloud.google.com/compute/docs/instances/create-start-instance

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@product-auto-label product-auto-label bot added api: compute Issues related to the googleapis/python-compute API. samples Issues that are directly related to samples. labels Oct 14, 2021
@snippet-bot
Copy link

snippet-bot bot commented Oct 14, 2021 •
edited
Loading

Here is the summary of changes.

You are about to add 30 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Oct 14, 2021
@m-strzelczyk m-strzelczyk added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 14, 2021
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 14, 2021
Xmasreturns
Xmasreturns reviewed Oct 15, 2021
View reviewed changes
Copy link
Contributor

@Xmasreturns Xmasreturns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sending this over. I think most of my comments can apply across several methods, so the later versions of creating a VM can hopefully get updated with some find/replace.

samples/snippets/sample_create_vm.py Outdated Show resolved Hide resolved
samples/snippets/sample_create_vm.py Outdated Show resolved Hide resolved
samples/snippets/sample_create_vm.py Outdated Show resolved Hide resolved
samples/snippets/sample_create_vm.py Outdated Show resolved Hide resolved
samples/snippets/sample_create_vm.py Show resolved Hide resolved
samples/snippets/sample_create_vm.py Show resolved Hide resolved
samples/snippets/sample_create_vm.py Outdated Show resolved Hide resolved
samples/snippets/sample_create_vm.py Outdated Show resolved Hide resolved
samples/snippets/sample_create_vm.py Outdated Show resolved Hide resolved
samples/snippets/sample_create_vm.py Outdated Show resolved Hide resolved
@m-strzelczyk m-strzelczyk marked this pull request as ready for review October 18, 2021 12:44
@m-strzelczyk m-strzelczyk requested review from a team as code owners October 18, 2021 12:44
@m-strzelczyk m-strzelczyk requested a review from parthea October 18, 2021 12:44
@m-strzelczyk m-strzelczyk merged commit 7293577 into main Oct 19, 2021
@m-strzelczyk m-strzelczyk deleted the samples-create-vm branch October 19, 2021 14:03
@m-strzelczyk m-strzelczyk mentioned this pull request Oct 22, 2021
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Xmasreturns Xmasreturns Xmasreturns left review comments

@parthea parthea parthea approved these changes

Assignees
No one assigned
Labels
api: compute Issues related to the googleapis/python-compute API. cla: yes This human has signed the Contributor License Agreement. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@m-strzelczyk @parthea @Xmasreturns @yoshi-kokoro