This repository has been archived by the owner on Dec 31, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: Adding firewall samples. #117
feat: Adding firewall samples. #117
Changes from 6 commits
a363752
ed958be
aba4a33
e0b9707
9255ce0
fb39d22
1a2ab24
fe40b40
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For usage in default values presentation we should probably mention that this will get priority of 1000. This code is not part of the sample, so maybe it should be added in the create_firewall_rule - similar to how we did it in set_usage_reports examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a comment, but I'm not sure how to gracefully add this to the create_firewall_rule sample, without adding the whole code block, which also contains call to functions from outside this sample.
I also expanded the comment in the
create_firewall_rule
function, to better explain what's going on around the priority.