This repository has been archived by the owner on Dec 31, 2023. It is now read-only.
Updates to create_firewall_rule sample #133
Assignees
Labels
api: compute
Issues related to the googleapis/python-compute API.
samples
Issues that are directly related to samples.
type: feature request
‘Nice-to-have’ improvement, new feature or different behavior or design.
Comments
m-strzelczyk
added a commit
that referenced
this issue
Oct 18, 2021
Applying suggested changes. Closes #133
m-strzelczyk
added a commit
that referenced
this issue
Oct 18, 2021
Applying suggested changes. Closes #133
3 tasks
m-strzelczyk
added a commit
that referenced
this issue
Oct 18, 2021
Applying suggested changes. Closes #133
parthea
added a commit
that referenced
this issue
Nov 8, 2021
Applying suggested changes. Closes #133 Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Based on my discussion with @jskeet and @amanda-tarafa please update create_firewall_rule sample to be less permissive by setting Target Tags to
web.Additionally based on feedback from PHP sample review please change the variable name tcp_80_443_allowed to a more generic name such as
allowed_ports.The text was updated successfully, but these errors were encountered: