Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: pin sphinx to version 4.0.1 #701

Merged
merged 2 commits into from
Jun 16, 2021
Merged

chore: pin sphinx to version 4.0.1 #701

merged 2 commits into from
Jun 16, 2021

Conversation

parthea
Copy link
Contributor

@parthea parthea commented Jun 16, 2021

Fixes #700 🦕

@parthea parthea requested a review from a team June 16, 2021 10:56
@parthea parthea requested a review from a team as a code owner June 16, 2021 10:56
@parthea parthea requested review from stephaniewang526 and removed request for a team June 16, 2021 10:56
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jun 16, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 16, 2021
@plamut plamut merged commit 8cfdda8 into master Jun 16, 2021
@plamut plamut deleted the pin-sphinx branch June 16, 2021 11:17
@plamut
Copy link
Contributor

plamut commented Jun 16, 2021

@parthea So the issue was just about updating the Sphinx version pin, right, and not switching to the autogenerated noxfile (yet)?

@dandhlee
Copy link
Contributor

for now, yes, pinning the version will help to not scare folks with surprise Sphinx version updates :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plamut plamut plamut approved these changes

@stephaniewang526 stephaniewang526 Awaiting requested review from stephaniewang526

Assignees
No one assigned
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Noxfile is not updated with Sphinx version pin
3 participants
@parthea @plamut @dandhlee