Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add property for maxStaleness in table definitions #2087

Merged
merged 2 commits into from
Dec 6, 2024
Merged

feat: add property for maxStaleness in table definitions #2087

merged 2 commits into from
Dec 6, 2024

Conversation

yu-iskw
Copy link
Contributor

@yu-iskw yu-iskw commented Dec 5, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2086 🦕

Reference

@yu-iskw
feat: add property for maxStaleness in table definitions
922f769 
Signed-off-by: Yu Ishikawa <yu-iskw@users.noreply.github.com>
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Dec 5, 2024
@yu-iskw yu-iskw marked this pull request as ready for review December 5, 2024 02:46
@yu-iskw yu-iskw requested review from a team as code owners December 5, 2024 02:46
@yu-iskw yu-iskw requested a review from hongalex December 5, 2024 02:46
@Linchin Linchin added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 5, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 5, 2024
@Linchin Linchin assigned Linchin and unassigned GaoleMeng Dec 5, 2024
@Linchin Linchin enabled auto-merge (squash) December 5, 2024 18:14
@Linchin Linchin self-requested a review December 5, 2024 18:14
@Linchin Linchin added the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 6, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 6, 2024
@Linchin Linchin merged commit 729322c into googleapis:main Dec 6, 2024
17 checks passed
@release-please release-please bot mentioned this pull request Dec 6, 2024
Merged
chalmerlowe pushed a commit that referenced this pull request Jan 2, 2025
@yu-iskw @Linchin @chalmerlowe
feat: add property for maxStaleness in table definitions (#2087)
39d4c1d 
* feat: add property for maxStaleness in table definitions

Signed-off-by: Yu Ishikawa <yu-iskw@users.noreply.github.com>

* Update google/cloud/bigquery/table.py

---------

Signed-off-by: Yu Ishikawa <yu-iskw@users.noreply.github.com>
Co-authored-by: Lingqing Gan <lingqing.gan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Linchin Linchin Linchin approved these changes

@hongalex hongalex Awaiting requested review from hongalex hongalex is a code owner automatically assigned from googleapis/api-bigquery

Assignees

@Linchin Linchin

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Property for maxStaleness in Table Definitions
4 participants
@yu-iskw @Linchin @GaoleMeng @yoshi-kokoro