feat: adds ForeignTypeInfo test #2076
Merged
+33
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…thub.com/googleapis/python-bigquery into feat-b358215039-add-foreigntypeinfo-test
suzmue
approved these changes
Nov 22, 2024
| @@ -598,61 +598,6 @@ def to_api_repr(self) -> dict: | |||
| return answer | |||
|
|
|||
|
|
|||
| class TableSchema: | |||
There was a problem hiding this comment.
nit: with this much removed code that isnt relevant to the change, it would probably make sense to have that as a separate PR (for next time don't need to move it now)
| klass = self._get_target_class() | ||
| result = klass.from_api_repr(resource) | ||
|
|
||
| assert result.to_api_repr() == expected.to_api_repr() |
There was a problem hiding this comment.
Similar feedback to the other CL, though maybe though now I'm thinking maybe we need to test that from_api_repr has the same response, though since to_api_repr is tested I think this is actually ok.
Your doc comment does describe that the results we are comparing are displayed as a dict, maybe its just the test naming that is throwing it off for me (maybe test_convert_api_repr or something?). Either way do think its fine to leave as is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a test to the test sets for ForeignTypeInfo.
Also removed
class TableSchemaas unneeded.