Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Job result returns proper page when start_index and page_size are not null #2046

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

manucalop
Copy link

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1569 🦕

@manucalop manucalop requested review from a team as code owners October 24, 2024 13:38
@manucalop manucalop requested a review from Neenu1995 October 24, 2024 13:38
Copy link

google-cla bot commented Oct 24, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Oct 24, 2024
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Oct 24, 2024
@manucalop
Copy link
Author

manucalop commented Oct 24, 2024

CLA is fixed now

@manucalop
Copy link
Author

Hi! Any updates on this? Could someone rerun the CLA job? I've already updated my status

@chalmerlowe
Copy link
Collaborator

Thanks for submitting a PR.

I took a quick look.

  • Gonna run our CI/CD checks on this.
  • My first thought is that because we are adding a couple code paths coverage is likely to fail.

@chalmerlowe chalmerlowe added the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 18, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Nov 18, 2024
@manucalop
Copy link
Author

Hi! Any update on this? Anything I can do to help?

@chalmerlowe
Copy link
Collaborator

@manucalop

I will do my best to take a look at this PR today. I appreciate your time and effort to help out the project.

@chalmerlowe chalmerlowe added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Dec 11, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Dec 11, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Dec 11, 2024
@chalmerlowe
Copy link
Collaborator

I got derailed yesterday. I am looking at a number of issues related to page_size handling by the bigquery library, so this is on my radar, I just didn't have a change to look closely.

I do see that coverage was not happy with this change so we will potentially need to consider the addition of a test or two to ensure that we fully exercise all the code paths around and through this code change.

Name                                Stmts   Miss Branch BrPart  Cover   Missing
-------------------------------------------------------------------------------
google/cloud/bigquery/job/query.py    801      1    170      1    99%   1551

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
4 participants