feat: add type hints to Client #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
chalmerlowe
reviewed
Nov 21, 2024
google/cloud/bigquery/client.py
Outdated
Comment on lines
244
to
249
| if client_options is None: | ||
| client_options = {} | ||
| if isinstance(client_options, dict): | ||
| client_options = google.api_core.client_options.from_dict(client_options) | ||
| assert isinstance(client_options, google.api_core.client_options.ClientOptions) | ||
|
|
There was a problem hiding this comment.
I am curious, why did we choose to:
- move this content from after the call to
super()to before the call tosuper()? What is the reason for reordering this content? - add an assert statement when one was not used previously?
There was a problem hiding this comment.
- Moving this part before the call to
super()is optional, but I did it because actually the exact same type check & coercion happens inside thesuper()(Client.__init__) as well, so I let it early break in the second time. - The reason for adding the assert statement is to let the type checker know the type of
client_options, otherwise it wouldn't know that theif client_options.api_endpoint:expression at the line 261 is valid .
|
@rinarakaki I ran the kokoro CI/CD checks. mypy errors:unit test errors: |
Moves import from being used solely during specific checks to being more universally available.
chalmerlowe
reviewed
Dec 10, 2024
testing some minor changes to deal with mypy quirks
chalmerlowe
reviewed
Dec 10, 2024
|
Thanks for providing this update to the code. |
chalmerlowe
added a commit
that referenced
this pull request
Jan 2, 2025
* add type hints * Update client.py Moves import from being used solely during specific checks to being more universally available. * Update google/cloud/bigquery/client.py * Update client.py testing some minor changes to deal with mypy quirks * Update google/cloud/bigquery/client.py --------- Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕