Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add classes and objects to enable PANGEA support #2012

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from

Conversation

chalmerlowe
Copy link
Collaborator

WIP: do not merge.

Internal reference: b/358215039

Copy link

conventional-commit-lint-gcf bot commented Sep 4, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquery Issues related to the googleapis/python-bigquery API. labels Sep 4, 2024
@chalmerlowe

This comment was marked as outdated.

@Linchin
Copy link
Contributor

Linchin commented Sep 5, 2024

Thank you for working to add PANGEA support! It's great that I can do a quick review early to make sure we are on the same page. I think the approach looks good, but I left a few comments on implementation details.

Also, before generating the rest, I think it'd be helpful to add tests to ensure the current code is working as intended.

@chalmerlowe
Copy link
Collaborator Author

Thank you for working to add PANGEA support! It's great that I can do a quick review early to make sure we are on the same page. I think the approach looks good, but I left a few comments on implementation details.

Also, before generating the rest, I think it'd be helpful to add tests to ensure the current code is working as intended.

Tests are next on my list for this first batch of classes.
With some proof of concept classes and tests in hand, we should be able to move on and add the remaining classes.

@chalmerlowe chalmerlowe self-assigned this Sep 11, 2024
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Sep 12, 2024
@Linchin Linchin added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 12, 2024
tests/unit/test_schema.py Outdated Show resolved Hide resolved
google/cloud/bigquery/_helpers.py Outdated Show resolved Hide resolved
google/cloud/bigquery/_helpers.py Outdated Show resolved Hide resolved
Copy link
Contributor

@suzmue suzmue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the changes! I think this update looks really good.

google/cloud/bigquery/_helpers.py Outdated Show resolved Hide resolved
Co-authored-by: Suzy Mueller <suzmue@google.com>
@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: l Pull request size is large. labels Nov 1, 2024
tests/unit/test_dataset.py Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants