-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add classes and objects to enable PANGEA support #2012
base: main
Are you sure you want to change the base?
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
This comment was marked as outdated.
This comment was marked as outdated.
Thank you for working to add PANGEA support! It's great that I can do a quick review early to make sure we are on the same page. I think the approach looks good, but I left a few comments on implementation details. Also, before generating the rest, I think it'd be helpful to add tests to ensure the current code is working as intended. |
Tests are next on my list for this first batch of classes. |
Co-authored-by: Suzy Mueller <suzmue@google.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making the changes! I think this update looks really good.
Co-authored-by: Suzy Mueller <suzmue@google.com>
3867638
to
d71d904
Compare
WIP: do not merge.
Internal reference:
b/358215039