Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: share design document for query retry logic #1123

Merged
merged 5 commits into from
Jun 27, 2022
Merged

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Jan 28, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards internal support ticket 29904196 🦕

@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jan 28, 2022
@tswast tswast closed this Mar 30, 2022
@tswast
Copy link
Contributor Author

tswast commented Jun 22, 2022

Reopening, as another large customer is also interested in this documentation.

We may want to add some "known issues" linking to general job retries. #969

@tswast tswast reopened this Jun 22, 2022
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jun 22, 2022
@tswast tswast marked this pull request as ready for review June 22, 2022 21:27
@tswast tswast requested a review from a team June 22, 2022 21:27
@tswast tswast requested a review from a team as a code owner June 22, 2022 21:27
@tswast tswast requested a review from steffnay June 22, 2022 21:27
@dandhlee dandhlee self-assigned this Jun 24, 2022
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor nit.

docs/design/query-retries.md Outdated Show resolved Hide resolved
Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
@steffnay steffnay merged commit 2cc4c0b into main Jun 27, 2022
@steffnay steffnay deleted the query-retries-design branch June 27, 2022 19:39
waltaskew pushed a commit to waltaskew/python-bigquery that referenced this pull request Jul 20, 2022
* doc: share design document for query retry logic

* add design document to contents tree

* clarify a few points

* Update docs/design/query-retries.md

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
* doc: share design document for query retry logic

* add design document to contents tree

* clarify a few points

* Update docs/design/query-retries.md

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants