Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failing tests due to a change in the google public dataset: hacker news #1590

Closed
chalmerlowe opened this issue Jun 21, 2023 · 0 comments · Fixed by #1591
Closed

Failing tests due to a change in the google public dataset: hacker news #1590

chalmerlowe opened this issue Jun 21, 2023 · 0 comments · Fixed by #1591
Labels
type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@chalmerlowe
Copy link
Collaborator

A change in the Google public datasets caused four tests that rely on hacker news content began to fail.

Update the tests to ensure that they don't continue to fail.

Internal reference to the Google Bug: #286074582
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Jun 21, 2023
@chalmerlowe chalmerlowe added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. and removed api: bigquery Issues related to the googleapis/python-bigquery API. labels Jun 21, 2023
@chalmerlowe chalmerlowe mentioned this issue Jun 21, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 21, 2023
@chalmerlowe
fix: updates tests based on revised hacker_news tables (#1591)
d73cf49 
This fixes four broken tests that failed due to an unexpected change in the Google Public Dataset: Hacker News.

The `comments` table was deleted and only the `full` table remained.

This edit updates the name of the table in four tests and updates the names of columns in the table as well as updates the expected results for one of the tests.

Fixes #1590 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: updates tests based on revised hacker_news tables googleapis/python-bigquery
1 participant
@chalmerlowe