Skip to content

Commit

Permalink
testing: remove testing identity override (#2011)
Browse files Browse the repository at this point in the history
* testing: remove testing identity override

This PR removes a stale reference to a membership group in samples
tests.
  • Loading branch information
shollyman authored Sep 4, 2024
1 parent ea69fe3 commit 7af6523
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 3 deletions.
2 changes: 1 addition & 1 deletion samples/snippets/view.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ def grant_access(
# Make an API request to get the view dataset ACLs.
view_dataset = client.get_dataset(view_dataset_id)

analyst_group_email = "data_analysts@example.com"
analyst_group_email = "example-analyst-group@google.com"
# [END bigquery_grant_view_access]
# To facilitate testing, we replace values with alternatives
# provided by the testing harness.
Expand Down
3 changes: 1 addition & 2 deletions samples/snippets/view_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -114,7 +114,6 @@ def test_view(

project_id, dataset_id, table_id = view_id.split(".")
overrides: view.OverridesDict = {
"analyst_group_email": "cloud-dpes-bigquery@google.com",
"view_dataset_id": view_dataset_id,
"source_dataset_id": source_dataset_id,
"view_reference": {
Expand All @@ -127,5 +126,5 @@ def test_view(
assert len(view_dataset.access_entries) != 0
assert len(source_dataset.access_entries) != 0
out, _ = capsys.readouterr()
assert "cloud-dpes-bigquery@google.com" in out
assert "example-analyst-group@google.com" in out
assert table_id in out

0 comments on commit 7af6523

Please sign in to comment.