Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make read_session no longer DEPRECATED #765

Merged
merged 3 commits into from
Apr 11, 2024
Merged

fix: make read_session no longer DEPRECATED #765

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4a025b6
fix: make read_session no longer DEPRECATED
Linchin Apr 3, 2024
5ff4cd6
Merge branch 'main' into undeprecate
Linchin Apr 8, 2024
cf10aa2
Merge branch 'main' into undeprecate
chalmerlowe Apr 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 12 additions & 12 deletions google/cloud/bigquery_storage_v1/reader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,11 +228,11 @@ def rows(self, read_session=None):
read_session ( \
Optional[~google.cloud.bigquery_storage_v1.types.ReadSession] \
):
DEPRECATED.

This argument was used to specify the schema of the rows in the
stream, but now the first message in a read stream contains
this information.
this information. When row_restriction is applied, some streams
may be empty without read_session info. Provide this argument
to avoid an error. For more information, see https://github.com/googleapis/python-bigquery-storage/issues/733

Returns:
Iterable[Mapping]:
Expand All @@ -250,11 +250,11 @@ def to_arrow(self, read_session=None):
read_session ( \
~google.cloud.bigquery_storage_v1.types.ReadSession \
):
DEPRECATED.

This argument was used to specify the schema of the rows in the
stream, but now the first message in a read stream contains
this information.
this information. When row_restriction is applied, some streams
may be empty without read_session info. Provide this argument
to avoid an error. For more information, see https://github.com/googleapis/python-bigquery-storage/issues/733

Returns:
pyarrow.Table:
Expand All @@ -276,11 +276,11 @@ def to_dataframe(self, read_session=None, dtypes=None):
read_session ( \
~google.cloud.bigquery_storage_v1.types.ReadSession \
):
DEPRECATED.

This argument was used to specify the schema of the rows in the
stream, but now the first message in a read stream contains
this information.
this information. When row_restriction is applied, some streams
may be empty without read_session info. Provide this argument
to avoid an error. For more information, see https://github.com/googleapis/python-bigquery-storage/issues/733
dtypes ( \
Map[str, Union[str, pandas.Series.dtype]] \
):
Expand Down Expand Up @@ -308,11 +308,11 @@ class ReadRowsIterable(object):
read_session ( \
Optional[~google.cloud.bigquery_storage_v1.types.ReadSession] \
):
DEPRECATED.

This argument was used to specify the schema of the rows in the
stream, but now the first message in a read stream contains
this information.
this information. When row_restriction is applied, some streams
may be empty without read_session info. Provide this argument
to avoid an error. For more information, see https://github.com/googleapis/python-bigquery-storage/issues/733ß
"""

# This class is modelled after the google.cloud.bigquery.table.RowIterator
Expand Down