-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for proto3 optional tag #727
Conversation
Hi @Dumeng, thank you so much for making the contribution! Being compatible with proto3 would be very helpful. I have a few questions/suggestions:
Please let us know if you need any help, we are more than glad to work with you :) |
Hi @Linchin , Thanks for your reply.
|
1 similar comment
Hi @Linchin , Thanks for your reply.
|
Thanks for adding the system test! I think the system test has failed, and you can see the logs here. We also need to run the linter to pass the lint test. Also, as you can see we only have tests for v1. Since v1beta1 is going to be deprecated soon, and we don't have tests to verify that it works, I think it's a better idea to restrain our change here to v1. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding support for proto3!
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #726 🦕
The solution is similar to the fix in the Java client SDK.
googleapis/java-bigquerystorage#2295