Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add bigframes team as co-owners for pandas-gbq #847

Merged
merged 3 commits into from
Jan 6, 2025
Merged

chore: add bigframes team as co-owners for pandas-gbq #847

merged 3 commits into from
Jan 6, 2025

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Jan 6, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@tswast tswast requested review from a team as code owners January 6, 2025 16:25
@tswast tswast requested a review from whuffman36 January 6, 2025 16:25
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Jan 6, 2025
@tswast tswast added owlbot:run Add this label to trigger the Owlbot post processor. and removed size: xs Pull request size is extra small. labels Jan 6, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery-pandas API. label Jan 6, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 6, 2025
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 6, 2025
chalmerlowe
chalmerlowe approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@chalmerlowe chalmerlowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tswast tswast enabled auto-merge (squash) January 6, 2025 16:49
@tswast tswast merged commit c9fe842 into main Jan 6, 2025
22 of 25 checks passed
@tswast tswast deleted the tswast-patch-1 branch January 6, 2025 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalmerlowe chalmerlowe chalmerlowe approved these changes

@whuffman36 whuffman36 Awaiting requested review from whuffman36 whuffman36 is a code owner automatically assigned from googleapis/api-bigquery

Assignees

@chalmerlowe chalmerlowe

Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tswast @chalmerlowe