-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update intro.rst #79
Update intro.rst #79
Conversation
-Fix some grammar mistakes -Made explicit HTTPS calls
Minor grammar fixes
Codecov Report
@@ Coverage Diff @@
## master #79 +/- ##
===========================================
- Coverage 73.44% 28.17% -45.28%
===========================================
Files 4 4
Lines 1544 1544
===========================================
- Hits 1134 435 -699
- Misses 410 1109 +699
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alanyee for these updates! Just a couple minor observations.
docs/source/intro.rst
Outdated
Authentication to the Google ``BigQuery`` service is via ``OAuth 2.0``. | ||
Is possible to authenticate with either user account credentials or service account credentials. | ||
Authentication to the Google ``BigQuery`` service via ``OAuth 2.0`` | ||
is possible to authenticate with either user account credentials or service account credentials. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Authentication to the Google BigQuery
service via OAuth 2.0
is possible with either user or service account credentials.
docs/source/intro.rst
Outdated
which will be automatically opened for you. You will be authenticated to the specified | ||
``BigQuery`` account using the product name ``pandas GBQ``. It is only possible on local host. | ||
Authentication via user account credentials is as simple as following the prompts in a browser window | ||
which automatically open for you. You authenticate to the specified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
which will automatically open for you
docs/source/intro.rst
Outdated
``BigQuery`` account using the product name ``pandas GBQ``. It is only possible on local host. | ||
Authentication via user account credentials is as simple as following the prompts in a browser window | ||
which automatically open for you. You authenticate to the specified | ||
``BigQuery`` account using the product name ``pandas GBQ``, but only possible on local host. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the following text
, but only possible on local host
We support authenticating on both local and remote via the auth_local_webserver
argument of read_gbq
Correcting information via reviewer's recommendation
docs/source/intro.rst
Outdated
Authentication to the Google ``BigQuery`` service is via ``OAuth 2.0``. | ||
Is possible to authenticate with either user account credentials or service account credentials. | ||
Authentication to the Google ``BigQuery`` service via ``OAuth 2.0`` | ||
is possible to authenticate with either user or service account credentials. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Authentication to the Google BigQuery
service via OAuth 2.0
is possible to authenticate with either user or service account credentials.
Remove unnecessary words
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alanyee !
-Made explicit HTTPS calls
-Fixed minor grammar and whitespace issues