Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include api error info in raised errors #699

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

Linchin
Copy link
Contributor

@Linchin Linchin commented Nov 15, 2023

Part of fix for internal issue 219787554. This will make our error messages more actionable for users.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@Linchin Linchin requested a review from shollyman November 15, 2023 18:36
@Linchin Linchin requested review from a team as code owners November 15, 2023 18:36
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/python-bigquery-pandas API. labels Nov 15, 2023
@Linchin Linchin added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 15, 2023
@Linchin Linchin requested a review from chalmerlowe November 16, 2023 18:52
Copy link
Collaborator

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with some minor feedback on the string construction

@Linchin Linchin added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 17, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 17, 2023
@Linchin Linchin merged commit d921106 into googleapis:main Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery-pandas API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants