Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: install dependencies with Conda on py3.6 tests. #62

Merged
merged 1 commit into from
Jun 28, 2017

Conversation

tswast
Copy link
Collaborator

@tswast tswast commented Jun 22, 2017

Cover dependency installation via Conda in one of the CI tests.

Addresses #39 (comment)

@tswast
Copy link
Collaborator Author

tswast commented Jun 22, 2017

Note: Right now I'm getting a failure at https://travis-ci.org/tswast/pandas-gbq/jobs/245990533

$ if [ -f "$REQ.pip" ]; then pip install -r "$REQ.pip"; else conda install --file "$REQ.conda"; fi
Fetching package metadata ...........
PackageNotFoundError: Package missing in current linux-64 channels: 
  - google-auth
Close matches found; did you mean one of these?
    google-auth: google-apputils

I see the package at https://conda-forge.github.io/feedstocks, so I'm not sure what's going on.

@tswast
Copy link
Collaborator Author

tswast commented Jun 22, 2017

Ah, per https://conda-forge.github.io/ I think I need to add conda config --add channels conda-forge

@codecov-io
Copy link

codecov-io commented Jun 22, 2017

Codecov Report

Merging #62 into master will decrease coverage by 45.19%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #62      +/-   ##
==========================================
- Coverage   73.44%   28.24%   -45.2%     
==========================================
  Files           4        4              
  Lines        1540     1540              
==========================================
- Hits         1131      435     -696     
- Misses        409     1105     +696
Impacted Files Coverage Δ
pandas_gbq/gbq.py 19.35% <0%> (-55.98%) ⬇️
pandas_gbq/tests/test_gbq.py 27.94% <0%> (-54.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 852b2a3...70b2e9e. Read the comment docs.

@tswast
Copy link
Collaborator Author

tswast commented Jun 22, 2017

Looks like it is working now that I added the conda-forge channel. https://travis-ci.org/tswast/pandas-gbq/builds/245993672

@tswast
Copy link
Collaborator Author

tswast commented Jun 22, 2017

Hmmm... flake8 is failing now. I don't see how that could be related to this change. Maybe there was a change with flake8 versions.

Cover dependency installation via Conda in one of the tests.
@tswast
Copy link
Collaborator Author

tswast commented Jun 22, 2017

I updated the Travis config to run lint in the non-conda version. Not sure what is going on, since flake8 runs fine in my local conda environment.

@tswast
Copy link
Collaborator Author

tswast commented Jun 26, 2017

@jreback Is this what you had in mind?

@tswast
Copy link
Collaborator Author

tswast commented Jun 27, 2017

Ping.

Copy link
Contributor

@jreback jreback left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you show a successful run of this on your fork (the link)

@parthea
Copy link
Contributor

parthea commented Jun 28, 2017

@jreback Here is a successful test run from tswast:conda :
https://travis-ci.org/tswast/pandas-gbq/builds/246001341

@jreback
Copy link
Contributor

jreback commented Jun 28, 2017

lgtm

also just review any references in install docs, readme, and pandas docs

if anything needs updating (separate pr)

Copy link
Contributor

@parthea parthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @tswast !

@parthea parthea merged commit b0b0260 into googleapis:master Jun 28, 2017
@tswast tswast deleted the conda branch June 28, 2017 17:06
@parthea parthea mentioned this pull request Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants