-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: install dependencies with Conda on py3.6 tests. #62
Conversation
Note: Right now I'm getting a failure at https://travis-ci.org/tswast/pandas-gbq/jobs/245990533
I see the package at https://conda-forge.github.io/feedstocks, so I'm not sure what's going on. |
Ah, per https://conda-forge.github.io/ I think I need to add |
Codecov Report
@@ Coverage Diff @@
## master #62 +/- ##
==========================================
- Coverage 73.44% 28.24% -45.2%
==========================================
Files 4 4
Lines 1540 1540
==========================================
- Hits 1131 435 -696
- Misses 409 1105 +696
Continue to review full report at Codecov.
|
Looks like it is working now that I added the |
Hmmm... |
Cover dependency installation via Conda in one of the tests.
I updated the Travis config to run lint in the non-conda version. Not sure what is going on, since flake8 runs fine in my local conda environment. |
@jreback Is this what you had in mind? |
Ping. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you show a successful run of this on your fork (the link)
@jreback Here is a successful test run from tswast:conda : |
lgtm also just review any references in install docs, readme, and pandas docs if anything needs updating (separate pr) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @tswast !
Cover dependency installation via Conda in one of the CI tests.
Addresses #39 (comment)