-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COMPAT: drop 3.4 support #40
Conversation
TST: drop 3.4, add 3.6/0.20.1 to config matrix PEP setup.py
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
===========================================
- Coverage 73.72% 29.31% -44.41%
===========================================
Files 4 4
Lines 1511 1511
===========================================
- Hits 1114 443 -671
- Misses 397 1068 +671
Continue to review full report at Codecov.
|
@parthea this seems to break some tests. any idea? |
At first glance I'm not sure about the root cause of the broken tests but I will take a look tonight and fix them. |
I encountered similar test failures. Seems like the root cause is eventual consistency in the table and dataset listing on the BigQuery backend. Changing
|
There may be a BQ change that's caused this - all our internal integration tests with BQ have broken this week These are two SO questions that I posted over the last 24 hours: |
I'll poke the BigQuery engineers to see if there's something they could roll back. The fact that dataset listing can fail with the provided token is really annoying. |
TST: drop 3.4, add 3.6/0.20.1 to config matrix