chore: unimplemented API tracking #1269
Conversation
| self.method_name, | ||
| args, | ||
| kwargs, | ||
| task=PANDAS_API_TRACKING_TASK, |
There was a problem hiding this comment.
I'm a bit confused by this. Why the extra task argument?
There was a problem hiding this comment.
Task is to identify why the labels are collected. The PANDAS_API_TRACKING_TASK means the method is missing(like df.resample). The PANDAS_PARAM_TRACKING_TASK means args or kwargs are missing, but the method has already being implemented. Later in dashboard this may help.
| ) | ||
|
|
||
|
|
||
| def submit_pandas_labels( |
There was a problem hiding this comment.
Please add a docstring explaining the purpose of this method.
| @@ -30,6 +37,78 @@ | |||
| _call_stack: List = [] | |||
|
|
|||
|
|
|||
| class UnimplementedMethodLogger: | |||
| return method(*args, **kwargs) | ||
| return method(self, *args, **kwargs) | ||
| except (NotImplementedError, TypeError) as e: | ||
| if hasattr(self, "_block") and len(_call_stack) == 1: |
There was a problem hiding this comment.
Please add a comment explaining why we have these requirements in the if statement.
| 'pandas.DataFrame.{key}'. {constants.FEEDBACK_LINK} | ||
| """ | ||
| ) | ||
| return log_adapter.UnimplementedMethodLogger( |
There was a problem hiding this comment.
I'm confused. Why would we ever return this class to the user?
There was a problem hiding this comment.
Return this is because gettattr won't get the args and kwargs. By returning the class, the class will be called as a function and receive the args and kwargs, and then we can set the labels.
| 'pandas.Series.{key}'. {constants.FEEDBACK_LINK} | ||
| """ | ||
| ) | ||
| return log_adapter.UnimplementedMethodLogger( |
There was a problem hiding this comment.
Likewise, returning here seems wrong.
There was a problem hiding this comment.
Return this is because gettattr won't get the args and kwargs. By returning the class, the class will be called as a function and receive the args and kwargs, and then we can set the labels.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Currently this covers Series class and DataFrame class
Fixes #<issue_number_goes_here> 🦕