-
Notifications
You must be signed in to change notification settings - Fork 22
build: fix presubmit #257
build: fix presubmit #257
Conversation
if prerelease: | ||
session.install("-e", f"{working_dir}/{downstream_dir}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not move it outside the conditional logic like before and have a single session.install
towards the end. It seems to be that we probably just want to remove install_command.extend(["--no-deps"])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The install_prerelease_dependencies
has several install commands where we install pre-release versions of dependencies. I wanted to make sure to install the dependencies of the downstream client before upgrading to the pre-release versions of dependencies. If we did this at the end , we may downgrade the pre-release dependencies
* chore(python): update dependencies in .kokoro/docker/docs Source-Link: googleapis/synthtool@e808c98 Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e3e7e18255c22d1489258d0374c901c01f9c4fd77a12088670cd73d580aa737 * Add python 3.13 constraints file * Add python 3.13 to setup.py * Add python 3.13 to unittest.yml * Add python 3.13 to noxfile * Add flaky to test dependencies * See googleapis/python-api-common-protos#257 * lint * fix build * fix build * coverage * coverage --------- Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> Co-authored-by: Anthonios Partheniou <partheniou@google.com>
Fixes the error seen in #256 which occurred because opentelemetry was added as a direct dependency of
google-cloud-pubsub
and we run tests against pubsub via this codepython-api-common-protos/noxfile.py
Lines 175 to 176 in f30115b