This repository has been archived by the owner on Jan 18, 2025. It is now read-only.
Fix UnboundLocalError #301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Likely messed up in #276. |
|
Viewing https://api.github.com/repos/google/oauth2client/pulls/276/commits it seems the base for that PR was 043e066 At that point, the indent matches the change you made: |
|
LGTM. I did a side-by-side to make sure no other indents were screwed up. |
|
thanks 👏 |
|
Thank you for finding! (Hopefully once #212 is done we can be secure in the belief that there aren't lingering issues like this.) |
This was referenced Sep 11, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I try to use --noauth_local_webserver option, I'm receiving the exception:
"UnboundLocalError: local variable 'success' referenced before assignment"
Only a correct indentation was necessary.