Added support for pure Python RSA library when present.

[aeijdenberg]

Happy to add tests later once the tests are part of the main repo.

[craigcitro]

i'm good with leaving serious testing for a later patch -- but if possible, could you throw a few example input/output pairs into the BitStringToByteString docstring? even if we're testing them by hand, i'd like to have a clear record of what we expected that to do.

[skelterjohn]

I've added the test framework.

Please update your PR to include tests!

[skelterjohn]

You'll probably have to redo this PR - I've updated this repo using the history from the old googlecode repo, so things will probably not match. On the other hand, that transition has now taken place, so we can actually act on this pull request once it's settled.

[aeijdenberg]

John - it's unlikely I'll have time. Would you be able to pick it up?

On Thu, Apr 24, 2014 at 1:40 PM, John Asmuth notifications@github.comwrote:

You'll probably have to redo this PR - I've updated this repo using the
history from the old googlecode repo, so things will probably not match. On
the other hand, that transition has now taken place, so we can actually act
on this pull request once it's settled.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-41329388
.

[craigcitro]

I can if John can't, but not for another week or so.

---

-cc

sent from my phone
On Apr 24, 2014 4:26 PM, "aeijdenberg" notifications@github.com wrote:

John - it's unlikely I'll have time. Would you be able to pick it up?

On Thu, Apr 24, 2014 at 1:40 PM, John Asmuth notifications@github.comwrote:

You'll probably have to redo this PR - I've updated this repo using the
history from the old googlecode repo, so things will probably not match.
On
the other hand, that transition has now taken place, so we can actually
act
on this pull request once it's settled.

—
Reply to this email directly or view it on GitHub<
https://github.com/google/oauth2client/pull/1#issuecomment-41329388>
.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-41344670
.

[aeijdenberg]

Thank you.

On Thu, Apr 24, 2014 at 6:17 PM, Craig Citro notifications@github.comwrote:

I can if John can't, but not for another week or so.

---

-cc

sent from my phone
On Apr 24, 2014 4:26 PM, "aeijdenberg" notifications@github.com wrote:

John - it's unlikely I'll have time. Would you be able to pick it up?

On Thu, Apr 24, 2014 at 1:40 PM, John Asmuth notifications@github.comwrote:

You'll probably have to redo this PR - I've updated this repo using
the
history from the old googlecode repo, so things will probably not
match.
On
the other hand, that transition has now taken place, so we can
actually
act
on this pull request once it's settled.

—
Reply to this email directly or view it on GitHub<
https://github.com/google/oauth2client/pull/1#issuecomment-41329388>
.

—
Reply to this email directly or view it on GitHub<
https://github.com/google/oauth2client/pull/1#issuecomment-41344670>
.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1#issuecomment-41350726
.

[nathanielmanistaatgoogle]

It looks like you haven't yet signed Google's Contributor License Agreement - please do so?

[aeijdenberg]

Just submitted the GCLA today.

Cheers, Adam

On Tue, Mar 17, 2015 at 9:53 PM Nathaniel Manista notifications@github.com
wrote:

It looks like you haven't yet signed Google's Contributor License
Agreement - please do so?

—
Reply to this email directly or view it on GitHub
#1 (comment).

[dhermes]

@aeijdenberg Is this not already supported? pyasn1-modules is already a dependency.

[aeijdenberg]

It certainly wasn't in 2013 when I submitted the PR. :) I'll go check now.

[aeijdenberg]

So it looks like the support Orest added in 2014 for AppDefaultCredentials uses the pure Python module which is a good thing, however SignedJwtAssertionCredentials appears to live on inside of client.py and as far as I can tell still won't use the pure Python libraries.

I'm happy to redo this PR when I'm next back at my desk. I actually know how to use git now so it might be easier!

[dhermes]

Yeah I don't think Orest (or whoever else added the _service_account module) realized that SignedJwtAssertionCredentials existed (or that it could be used for service accounts).

I've been meaning to right that wrong with #211 but haven't had time (or at least time without higher priority issues). Let's continue this conversation over there (and maybe we'll end up filing a "use pure Python when necessary / possible" issue as well).

[anthmgoogle]

I have context with the changes to add the _service_account module. It was understood that SignedJwtAssertionCredentials existed, but it was tied to P12 and had a confusing name. The plan was that the new _ServiceAccountCredentials would replace as described in #211, but we kept it internal intially to avoid locking in the public surface before further review.

[dhermes]

I like it!