fix: capture and throw on non-existent files (#1969)

* fix: capture and throw on non-existent files * fix: use event handler instead of `pipeline` - TS doesn't support the pipeline `value` return in the callback yet...
googleapis · May 25, 2022 · 52d81c0 · 52d81c0
1 parent 637f0b0
commit 52d81c0
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/src/bucket.ts b/src/bucket.ts
@@ -3922,6 +3922,7 @@ class Bucket extends ServiceObject {
               writable.on('progress', options.onUploadProgress);
             }
             fs.createReadStream(pathString)
+              .on('error', bail)
               .pipe(writable)
               .on('error', err => {
                 if (

diff --git a/test/bucket.ts b/test/bucket.ts
@@ -2602,6 +2602,11 @@ describe('Bucket', () => {
   describe('upload', () => {
     const basename = 'testfile.json';
     const filepath = path.join(__dirname, '../../test/testdata/' + basename);
+    const nonExistentFilePath = path.join(
+      __dirname,
+      '../../test/testdata/',
+      'non-existent-file'
+    );
     const metadata = {
       metadata: {
         a: 'b',
@@ -3030,6 +3035,14 @@ describe('Bucket', () => {
         }
       );
     });
+
+    it('should capture and throw on non-existent files', done => {
+      bucket.upload(nonExistentFilePath, (err: Error) => {
+        assert(err);
+        assert(err.message.includes('ENOENT'));
+        done();
+      });
+    });
   });
 
   describe('makeAllFilesPublicPrivate_', () => {